eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[cmake] fix video_core and tests comp errors on Windows #2631

Merged
crueter merged 3 commits from fix-tests into master 2025-10-05 00:00:53 +02:00
Conversation 1 Commits 3 Files changed 2 +12 -1
crueter commented 2025-10-01 03:32:13 +02:00
Owner
Copy link

did not link to video_core thus did not properly propagate the GPUOpen
target thus failed to find vk_mem_alloc

also msvc sucks

Signed-off-by: crueter crueter@eden-emu.dev

did not link to video_core thus did not properly propagate the GPUOpen target thus failed to find vk_mem_alloc also msvc sucks Signed-off-by: crueter <crueter@eden-emu.dev>
crueter added 1 commit 2025-10-01 03:32:14 +02:00
[cmake] fix tests comp error on Windows
Some checks failed
eden-license / license-header (pull_request) Failing after 24s
Details
c2930505ce 
did not link to video_core thus did not properly propagate the GPUOpen
target thus failed to find vk_mem_alloc

Signed-off-by: crueter <crueter@eden-emu.dev>
requested reviews from Maufeat, MrPurple666, MaranBr, Lizzie, CamilleLaVey 2025-10-01 03:32:14 +02:00
crueter added 1 commit 2025-10-01 03:47:15 +02:00
pragma the warnings away
Some checks failed
eden-license / license-header (pull_request) Failing after 24s
Details
1ff378b62c 
i have literally no idea why the compile def did NOT work but alas

Signed-off-by: crueter <crueter@eden-emu.dev>
crueter changed title from [cmake] fix tests comp error on Windows to [cmake] fix video_core and tests comp errors on Windows 2025-10-01 03:47:22 +02:00
crueter added 1 commit 2025-10-01 03:47:36 +02:00
Fix license headers
All checks were successful
eden-license / license-header (pull_request) Successful in 23s
Details
4acc96d9ad
MaranBr force-pushed fix-tests from 4acc96d9ad to f5c40ced86 2025-10-01 06:38:00 +02:00 Compare
MaranBr approved these changes 2025-10-01 06:38:06 +02:00
MaranBr force-pushed fix-tests from f5c40ced86 to be320d0302 2025-10-05 00:00:21 +02:00 Compare
MaranBr scheduled this pull request to auto merge when all checks succeed 2025-10-05 00:00:35 +02:00
crueter merged commit 1a13e79c3d into master 2025-10-05 00:00:53 +02:00
crueter deleted branch fix-tests 2025-10-05 00:00:54 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Maufeat
MrPurple666
Lizzie
CamilleLaVey
MaranBr
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#2631
No description provided.
Delete branch "fix-tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?