eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[vk] Add missing flush per spec #2624

Merged
MaranBr merged 1 commit from Ribbit/ribbitvulkanadditions:layerchange into master 2025-10-02 20:00:35 +02:00
Conversation 3 Commits 1 Files changed 1 +1
Ribbit commented 2025-09-30 04:01:41 +02:00
Contributor
Copy link

We copy pixels into a CPU-side staging buffer and then ask the GPU to read from it. On some systems those CPU writes aren’t automatically visible to the GPU unless explicitly flushed, so the GPU can sometimes read stale data. By calling buffer.Flush() immediately after writing, we force those CPU changes to become visible to the device, ensuring the GPU sees the latest frame. However, this is an emulator, so sometimes what spec says may not work cause reasons.

We copy pixels into a CPU-side staging buffer and then ask the GPU to read from it. On some systems those CPU writes aren’t automatically visible to the GPU unless explicitly flushed, so the GPU can sometimes read stale data. By calling buffer.Flush() immediately after writing, we force those CPU changes to become visible to the device, ensuring the GPU sees the latest frame. However, this is an emulator, so sometimes what spec says may not work cause reasons.
Ribbit added 1 commit 2025-09-30 04:01:42 +02:00
[vk] Add missing flush per spec
All checks were successful
eden-license / license-header (pull_request) Successful in 21s
Details
508f3c1f69
Ribbit force-pushed layerchange from 508f3c1f69 to 38e05e205f 2025-09-30 13:24:52 +02:00 Compare
Shinmegumi force-pushed layerchange from 38e05e205f to 7f6d234845 2025-10-01 01:30:12 +02:00 Compare
Shinmegumi changed title from WIP: [vk] Add missing flush per spec to [vk] Add missing flush per spec 2025-10-02 17:49:50 +02:00
requested reviews from Lizzie, CamilleLaVey, Maufeat, crueter, MrPurple666, MaranBr 2025-10-02 17:49:51 +02:00
Shinmegumi force-pushed layerchange from 7f6d234845 to fab4fb05a7 2025-10-02 17:49:58 +02:00 Compare
Shinmegumi approved these changes 2025-10-02 17:50:14 +02:00
Shinmegumi commented 2025-10-02 17:50:48 +02:00
Owner
Copy link

Tested and confirmed that this does help reduce flicker or eliminate it in a number of titles. Performance has not been shown to be affected by this PR. Approved.

Tested and confirmed that this does help reduce flicker or eliminate it in a number of titles. Performance has not been shown to be affected by this PR. Approved.
MaranBr approved these changes 2025-10-02 18:14:43 +02:00
MaranBr merged commit 990a43a48c into master 2025-10-02 20:00:35 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Lizzie
CamilleLaVey
Maufeat
crueter
MrPurple666
Shinmegumi
MaranBr
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#2624
No description provided.
Delete branch "Ribbit/ribbitvulkanadditions:layerchange"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?