eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[cmake] fix apple, android builds #2619

Merged
crueter merged 4 commits from fix-appldfl into master 2025-09-30 02:18:32 +02:00
Conversation 4 Commits 4 Files changed 2 +36 -13
Lizzie commented 2025-09-29 21:04:39 +02:00
Member
Copy link

Signed-off-by: lizzie lizzie@eden-emu.dev

Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie added 1 commit 2025-09-29 21:04:39 +02:00
[cmake] fix apple, android builds
All checks were successful
eden-license / license-header (pull_request) Successful in 22s
Details
b4825af1a7 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
requested reviews from crueter, CamilleLaVey, Maufeat, MrPurple666, MaranBr 2025-09-29 21:04:39 +02:00
crueter requested changes 2025-09-29 21:22:46 +02:00
CMakeLists.txt Outdated
@ -211,3 +211,3 @@
option(YUZU_DOWNLOAD_TIME_ZONE_DATA "Always download time zone binaries" ON)
CMAKE_DEPENDENT_OPTION(YUZU_USE_FASTER_LD "Check if a faster linker is available" ON "NOT WIN32" OFF)
CMAKE_DEPENDENT_OPTION(YUZU_USE_FASTER_LD "Check if a faster linker is available" ON "ANDROID OR LINUX" OFF)
crueter commented 2025-09-29 21:22:43 +02:00
Owner
Copy link

disable on android

disable on android
crueter marked this conversation as resolved
crueter commented 2025-09-29 21:23:57 +02:00
Owner
Copy link

Or even better, search for bfd much like the other two are done, if none are found just warn (and only default ON for linux)

Or even better, search for bfd much like the other two are done, if none are found just warn (and only default ON for linux)
Lizzie added 1 commit 2025-09-29 22:05:25 +02:00
fx
All checks were successful
eden-license / license-header (pull_request) Successful in 21s
Details
fa131451e0 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie added 1 commit 2025-09-29 22:12:38 +02:00
fx
All checks were successful
eden-license / license-header (pull_request) Successful in 22s
Details
a279473550 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
requested review from crueter 2025-09-29 22:21:18 +02:00
crueter added 1 commit 2025-09-29 22:28:23 +02:00
prefer gold, fix bfd find_program
All checks were successful
eden-license / license-header (pull_request) Successful in 21s
Details
ff78ed68ea 
Signed-off-by: crueter <crueter@eden-emu.dev>
DraVee approved these changes 2025-09-29 22:42:55 +02:00
DraVee left a comment
Member
Copy link

Should be approved asap

Should be approved asap
src/android/app/src/main/res/values/strings.xml
@ -871,3 +871,3 @@
<string name="fatal_error">Fatal Error</string>
<string name="fatal_error_message">A fatal error occurred. Check the log for details.\nContinuing emulation may result in crashes.</string>
<string name="performance_warning">Turning off this setting will significantly degrade performance. It's recommended that you leave this setting enabled.</string>
<string name="performance_warning">Turning off this setting will significantly degrade performance. It&quot;s recommended that you leave this setting enabled.</string>
DraVee commented 2025-09-29 22:41:38 +02:00
Member
Copy link

Well, probably we will need to change it to \' or everything to &quot;

Well, probably we will need to change it to `\'` or everything to `&quot;`
MaranBr approved these changes 2025-09-30 01:35:41 +02:00
crueter merged commit f422d855b7 into master 2025-09-30 02:18:32 +02:00
crueter deleted branch fix-appldfl 2025-09-30 02:18:32 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
CamilleLaVey
Maufeat
MrPurple666
crueter
DraVee
MaranBr
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#2619
No description provided.
Delete branch "fix-appldfl"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?