eden-emu/eden
24
3
Fork 16
Code Issues 139 Pull requests 58 Projects 1 Releases Wiki Activity Actions

[common] No need to specify min/max for settings; fix crash when OOB value is given for some settings #2609

Merged
Shinmegumi merged 1 commit from liz-fix-settings-crash into master 2025-09-29 18:40:30 +02:00
Conversation 2 Commits 1 Files changed 4 +84 -150
Lizzie commented 2025-09-29 06:36:25 +02:00
Member
Copy link

This fixes issues when migrating settings that refer to invalid filters/scales. For example if we had 5 filters, but we set filter=6, the program would crash.
This also makes so specifying min/max manually isn't needed (but can still be set for cases like NCE).

Signed-off-by: lizzie lizzie@eden-emu.dev

This fixes issues when migrating settings that refer to invalid filters/scales. For example if we had 5 filters, but we set filter=6, the program would crash. This also makes so specifying min/max manually isn't needed (but can still be set for cases like NCE). Signed-off-by: lizzie <lizzie@eden-emu.dev>
crueter approved these changes 2025-09-29 15:48:58 +02:00
MaranBr approved these changes 2025-09-29 17:23:00 +02:00
Shinmegumi force-pushed liz-fix-settings-crash from 407e4f592b
All checks were successful
eden-license / license-header (pull_request) Successful in 20s
Details
to 77f5128408
All checks were successful
eden-license / license-header (pull_request) Successful in 22s
Details
2025-09-29 18:40:04 +02:00 Compare
Shinmegumi deleted branch liz-fix-settings-crash 2025-09-29 18:40:30 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
MrPurple666
CamilleLaVey
Maufeat
crueter
MaranBr
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!2609
No description provided.