eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[common/logging] faster logging by avoiding constructing unused strings/results (and filtering first) #2603

Merged
crueter merged 2 commits from liz-faster-logging1 into master 2025-10-01 23:18:38 +02:00
Conversation 6 Commits 2 Files changed 4 +45 -45
Lizzie commented 2025-09-27 22:37:16 +02:00
Member
Copy link

basically std::string would be invoked even when the logging was filtered, then destroyed instantly, invoking malloc/free and polluting mem arenas for no good reason

Signed-off-by: lizzie lizzie@eden-emu.dev

basically std::string would be invoked even when the logging was filtered, then destroyed instantly, invoking malloc/free and polluting mem arenas for no good reason Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie added 1 commit 2025-09-27 22:37:16 +02:00
[common/logging] faster logging by avoiding constructing unused strings/results (and filtering first)
Some checks failed
eden-license / license-header (pull_request) Failing after 25s
Details
2f327c786e 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
requested reviews from CamilleLaVey, Maufeat, crueter, MrPurple666, MaranBr 2025-09-27 22:37:16 +02:00
Lizzie added 1 commit 2025-09-27 23:23:49 +02:00
fx
All checks were successful
eden-license / license-header (pull_request) Successful in 25s
Details
616a1d38ab 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
MaranBr force-pushed liz-faster-logging1 from 616a1d38ab to e5fb598d77 2025-09-27 23:37:45 +02:00 Compare
DraVee approved these changes 2025-09-28 01:42:19 +02:00
MaranBr approved these changes 2025-09-28 01:47:39 +02:00
Dismissed
MaranBr force-pushed liz-faster-logging1 from e5fb598d77 to 4e65e3b192 2025-09-28 07:56:00 +02:00 Compare
MaranBr approved these changes 2025-09-28 16:28:59 +02:00
Dismissed
MaranBr force-pushed liz-faster-logging1 from 4e65e3b192 to e5844ac7ea 2025-10-01 03:32:29 +02:00 Compare
DraVee commented 2025-10-01 06:54:26 +02:00
Member
Copy link

I don't think this have any regression or improvement on speed as tested, should be good to approve since it's better to reduce unnecessary memory allocation

I don't think this have any regression or improvement on speed as tested, should be good to approve since it's better to reduce unnecessary memory allocation
requested review from Shinmegumi 2025-10-01 06:54:54 +02:00
MaranBr force-pushed liz-faster-logging1 from e5844ac7ea to 62525c2c17 2025-10-01 06:56:51 +02:00 Compare
MaranBr force-pushed liz-faster-logging1 from 62525c2c17 to d626641e9d 2025-10-01 07:01:26 +02:00 Compare
MaranBr approved these changes 2025-10-01 07:01:32 +02:00
MaranBr scheduled this pull request to auto merge when all checks succeed 2025-10-01 07:01:56 +02:00
MaranBr force-pushed liz-faster-logging1 from d626641e9d to 03d53e14d1 2025-10-01 23:11:44 +02:00 Compare
crueter approved these changes 2025-10-01 23:18:28 +02:00
crueter merged commit 76b5d6778e into master 2025-10-01 23:18:38 +02:00
crueter deleted branch liz-faster-logging1 2025-10-01 23:18:39 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
CamilleLaVey
Maufeat
MrPurple666
DraVee
Shinmegumi
MaranBr
crueter
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#2603
No description provided.
Delete branch "liz-faster-logging1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?