eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[meta] allow customisation of auto-updater, remove hardcoded title names and fix dup title names #2588

Merged
crueter merged 3 commits from liz-fix-scm-title-name into master 2025-10-01 05:08:01 +02:00
Conversation 4 Commits 3 Files changed 8 +43 -19
Lizzie commented 2025-09-26 10:47:11 +02:00
Member
Copy link

Right now on all platforms, sdl2 will display something like "Eden Eden | master-8gd8fg8", this fixes so it only displays Eden (the REPO_NAME) once.

Signed-off-by: lizzie lizzie@eden-emu.dev

Right now on all platforms, sdl2 will display something like "Eden Eden | master-8gd8fg8", this fixes so it only displays `Eden` (the REPO_NAME) once. Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie added 1 commit 2025-09-26 10:47:11 +02:00
[eden-cli] Fix title having duplicate name
Some checks failed
eden-license / license-header (pull_request) Failing after 22s
Details
a804392bd9 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
requested reviews from crueter, MrPurple666, MaranBr, CamilleLaVey, Maufeat 2025-09-26 10:47:11 +02:00
Lizzie added 1 commit 2025-09-26 11:05:16 +02:00
extend to auto updater
All checks were successful
eden-license / license-header (pull_request) Successful in 21s
Details
605a1eb7ca 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie changed title from [eden-cli] Fix title having duplicate name to [meta] allow customisation of auto-updater, remove hardcoded title names and fix dup title names 2025-09-26 11:06:01 +02:00
crueter approved these changes 2025-09-27 01:03:58 +02:00
Dismissed
crueter force-pushed liz-fix-scm-title-name from 605a1eb7ca to 20b21760ee 2025-09-27 01:04:03 +02:00 Compare
DraVee approved these changes 2025-09-27 05:39:57 +02:00
Dismissed
crueter changed title from [meta] allow customisation of auto-updater, remove hardcoded title names and fix dup title names to WIP: [meta] allow customisation of auto-updater, remove hardcoded title names and fix dup title names 2025-09-27 05:55:42 +02:00
crueter force-pushed liz-fix-scm-title-name from 20b21760ee to 2cb6ab2dde 2025-09-27 05:55:48 +02:00 Compare
Lizzie force-pushed liz-fix-scm-title-name from 2cb6ab2dde to 6e5113bef9 2025-09-27 15:02:51 +02:00 Compare
Lizzie changed title from WIP: [meta] allow customisation of auto-updater, remove hardcoded title names and fix dup title names to [meta] allow customisation of auto-updater, remove hardcoded title names and fix dup title names 2025-09-27 15:02:55 +02:00
requested review from crueter 2025-09-27 15:02:55 +02:00
Lizzie force-pushed liz-fix-scm-title-name from 6e5113bef9 to 3087eff9a6 2025-09-28 03:49:08 +02:00 Compare
crueter commented 2025-09-28 04:16:41 +02:00
Owner
Copy link
D:/a/Workflow/Workflow/build/src/common/scm_rev.cpp(40,22): error: unused variable 'g_build_auto_update_website' [-Werror,-Wunused-const-variable]
   40 | constexpr const char g_build_auto_update_website[] = BUILD_AUTO_UPDATE_WEBISTE;
      |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
D:/a/Workflow/Workflow/build/src/common/scm_rev.cpp(41,22): error: unused variable 'g_build_auto_update_api' [-Werror,-Wunused-const-variable]
   41 | constexpr const char g_build_auto_update_api[] = BUILD_AUTO_UPDATE_API;
      |                      ^~~~~~~~~~~~~~~~~~~~~~~
D:/a/Workflow/Workflow/build/src/common/scm_rev.cpp(42,22): error: unused variable 'g_build_auto_update_repo' [-Werror,-Wunused-const-variable]
   42 | constexpr const char g_build_auto_update_repo[] = BUILD_AUTO_UPDATE_REPO;
      |                      ^~~~~~~~~~~~~~~~~~~~~~~~
``` D:/a/Workflow/Workflow/build/src/common/scm_rev.cpp(40,22): error: unused variable 'g_build_auto_update_website' [-Werror,-Wunused-const-variable] 40 | constexpr const char g_build_auto_update_website[] = BUILD_AUTO_UPDATE_WEBISTE; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ D:/a/Workflow/Workflow/build/src/common/scm_rev.cpp(41,22): error: unused variable 'g_build_auto_update_api' [-Werror,-Wunused-const-variable] 41 | constexpr const char g_build_auto_update_api[] = BUILD_AUTO_UPDATE_API; | ^~~~~~~~~~~~~~~~~~~~~~~ D:/a/Workflow/Workflow/build/src/common/scm_rev.cpp(42,22): error: unused variable 'g_build_auto_update_repo' [-Werror,-Wunused-const-variable] 42 | constexpr const char g_build_auto_update_repo[] = BUILD_AUTO_UPDATE_REPO; | ^~~~~~~~~~~~~~~~~~~~~~~~ ```
MaranBr force-pushed liz-fix-scm-title-name from 3087eff9a6 to 7706bc554c 2025-09-28 07:57:21 +02:00 Compare
Lizzie force-pushed liz-fix-scm-title-name from 7706bc554c to 77a6e595d8 2025-09-30 03:51:52 +02:00 Compare
Lizzie dismissed crueter's review 2025-09-30 03:51:52 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Lizzie dismissed DraVee's review 2025-09-30 03:51:52 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Lizzie force-pushed liz-fix-scm-title-name from 77a6e595d8 to 443c95721e 2025-09-30 10:36:43 +02:00 Compare
crueter approved these changes 2025-10-01 05:07:54 +02:00
crueter merged commit 91fb1df624 into master 2025-10-01 05:08:01 +02:00
crueter deleted branch liz-fix-scm-title-name 2025-10-01 05:08:02 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
MrPurple666
MaranBr
CamilleLaVey
Maufeat
crueter
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#2588
No description provided.
Delete branch "liz-fix-scm-title-name"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?