eden-emu/eden
24
3
Fork 16
Code Issues 139 Pull requests 58 Projects 1 Releases Wiki Activity Actions

WIP: [VK] BufferCache fixes not to be merged yet just for benchmarks #258

Closed
wildcard wants to merge 1 commit from buffercache_test into master
pull from: buffercache_test
merge into: eden-emu:master
Conversation 1 Commits 1 Files changed 1 +12 -12
wildcard commented 2025-08-14 00:19:42 +02:00
Member
Copy link

DMAClear now treats amount as bytes and marks the region GPU-modified (not subtracting, one of the reasons why need benchmarking].
The page-scanner in IsRegionRegistered() now advances with buf_end_addr so there should be no infinite loop now.
Overlap growth now expands left with expand_begin and right with expand_end (should stop stream buffers thrashing).
Also Skipping zero-fill on new buffers to save bandwidth and is probably safe since we are doing sync in upload paths before GPU reads.

DMAClear now treats amount as bytes and marks the region GPU-modified (not subtracting, one of the reasons why need benchmarking]. The page-scanner in IsRegionRegistered() now advances with buf_end_addr so there should be no infinite loop now. Overlap growth now expands left with expand_begin and right with expand_end (should stop stream buffers thrashing). Also Skipping zero-fill on new buffers to save bandwidth and is probably safe since we are doing sync in upload paths before GPU reads.
Shinmegumi force-pushed buffercache_test from 3253af8a9c
All checks were successful
eden-license / license-header (pull_request) Successful in 16s
Details
to 4fca875a78
All checks were successful
eden-license / license-header (pull_request) Successful in 18s
Details
2025-08-14 14:39:03 +02:00 Compare
Shinmegumi force-pushed buffercache_test from 4fca875a78
All checks were successful
eden-license / license-header (pull_request) Successful in 18s
Details
to 4c76be32fb
All checks were successful
eden-license / license-header (pull_request) Successful in 25s
Details
2025-08-24 01:16:23 +02:00 Compare
Shinmegumi force-pushed buffercache_test from 4c76be32fb
All checks were successful
eden-license / license-header (pull_request) Successful in 25s
Details
to 4de2faf940
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
Details
2025-09-01 15:31:12 +02:00 Compare
Shinmegumi commented 2025-09-01 15:48:15 +02:00
Owner
Copy link

Closing per @wildcard

Closing per @wildcard
Shinmegumi closed this pull request 2025-09-01 15:48:15 +02:00
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
Required
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!258
No description provided.