eden-emu/eden
24
3
Fork 16
Code Issues 139 Pull requests 56 Projects 1 Releases Wiki Activity Actions

WIP: [core] let OS control affinity of threads as opposed to manually setting #2571

Closed
Lizzie wants to merge 3 commits from liz-thread-competition-experiment into master
pull from: liz-thread-competition-experiment
merge into: eden-emu:master
Conversation 3 Commits 3 Files changed 9 +4 -65
Lizzie commented 2025-09-25 02:40:15 +02:00
Member
Copy link

This will make the CFS in Linux kernels be happy (as marking too many threads as critical actually reduces performance). The load balancing gets distributed evenly across the 4 cores which will outperform in a 8-core setup system. We still have over 40 threads but this SHOULD help to reduce thread contention (especially since the CPU thread is one of the most important to run). The scheduling should be ideally left to the OS as most of them have decades of running proficient scheduling algorithms which likely outperforms any hand-made solutions.

Signed-off-by: lizzie lizzie@eden-emu.dev

This will make the CFS in Linux kernels be happy (as marking too many threads as critical actually reduces performance). The load balancing gets distributed evenly across the 4 cores which will outperform in a 8-core setup system. We still have over 40 threads but this *SHOULD* help to reduce thread contention (especially since the CPU thread is one of the most important to run). The scheduling should be ideally left to the OS as most of them have decades of running proficient scheduling algorithms which likely outperforms any hand-made solutions. Signed-off-by: lizzie <lizzie@eden-emu.dev>
[core] give exclusive affinity control to CPU threads
Some checks failed
eden-license / license-header (pull_request) Failing after 20s
Details
8620d9cbe5
 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
fix license
All checks were successful
eden-license / license-header (pull_request) Successful in 18s
Details
1484724ee9
 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
CamilleLaVey approved these changes 2025-09-25 02:59:04 +02:00
Dismissed
MaranBr approved these changes 2025-09-25 03:08:05 +02:00
Dismissed
noone gets thread affinity controls
All checks were successful
eden-license / license-header (pull_request) Successful in 20s
Details
4150452f5a
 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie dismissed CamilleLaVey's review 2025-09-25 05:25:40 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Lizzie dismissed MaranBr's review 2025-09-25 05:25:40 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Lizzie changed title from [core] give exclusive affinity control to CPU threads to WIP: [core] give exclusive affinity control to CPU threads 2025-09-25 05:28:29 +02:00
Lizzie changed title from WIP: [core] give exclusive affinity control to CPU threads to WIP: [core] let OS control affinity of threads as opposed to manually setting 2025-09-25 05:29:25 +02:00
Lizzie commented 2025-10-16 20:04:28 +02:00
Author
Member
Copy link

bad pr with bad results

bad pr with bad results
Lizzie closed this pull request 2025-10-16 20:04:29 +02:00
All checks were successful
eden-license / license-header (pull_request) Successful in 20s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Maufeat
crueter
MrPurple666
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!2571
No description provided.