eden-emu/eden
24
3
Fork 16
Code Issues 139 Pull requests 56 Projects 1 Releases Wiki Activity Actions

WIP: [clang, cmake] Fix building with fmt 10 (default ubuntu 25.04) and with LTO on Clang (again) #2504

Closed
DraVee wants to merge 5 commits from DraVee:another-fix/clang-on-ubuntu into master
pull from: DraVee:another-fix/clang-on-ubuntu
merge into: eden-emu:master
Conversation 1 Commits 5 Files changed 7 +147 -51
DraVee commented 2025-09-18 04:03:19 +02:00
Member
Copy link

af82eb0e19: @crueter this commit is just a fix proposed by chatgpt, a better fix should be made to fix this https://pastebin.com/PbaFXrBa

af82eb0e19f747343af0be486fd5ee6f8c378edb: @crueter this commit is just a fix proposed by chatgpt, a better fix should be made to fix this https://pastebin.com/PbaFXrBa
Signed-off-by: Caio Oliveira <caiooliveirafarias0@gmail.com>
* based off: https://stackoverflow.com/questions/73011966/unable-to-compile-c-program-with-clang-14

Signed-off-by: Caio Oliveira <caiooliveirafarias0@gmail.com>
* we should avoid this, better to set each option per case

Signed-off-by: Caio Oliveira <caiooliveirafarias0@gmail.com>
[cmake/meta] group and comment things
All checks were successful
eden-license / license-header (pull_request) Successful in 42s
Details
05a91aa06c
 
Signed-off-by: Caio Oliveira <caiooliveirafarias0@gmail.com>
crueter requested changes 2025-09-18 14:51:29 +02:00
CMakeLists.txt Outdated
@ -231,0 +240,4 @@
# Compiler / Platform Specific Defaults
# For MSVC or Android, enforce external SDL2, CPM, bundled FFmpeg, and precompiled headers.
if (MSVC OR ANDROID)
crueter commented 2025-09-18 14:51:16 +02:00
Owner
Copy link

If we're going to enforce it, just use CMakeDependentOption.

If we're going to enforce it, just use CMakeDependentOption.
👍 1
[DO NOT MERGE] WIP
All checks were successful
eden-license / license-header (pull_request) Successful in 18s
Details
746372c363
 
Signed-off-by: Caio Oliveira <caiooliveirafarias0@gmail.com>
DraVee closed this pull request 2025-09-19 04:08:04 +02:00
All checks were successful
eden-license / license-header (pull_request) Successful in 18s
Required
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Lizzie
crueter
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!2504
No description provided.