[Vk] FixSampleShading #218

Merged
crueter merged 2 commits from wildcard/eden:FixSampleShading into master 2025-08-15 01:17:39 +02:00
Member
No description provided.
wildcard added 2 commits 2025-08-07 19:16:00 +02:00
[ VUID-vkCmdPipelineBarrier-dstAccessMask-02816 ] The Vulkan spec states: The dstAccessMask member of each element of pMemoryBarriers must only include access flags that are supported by one or more of the pipeline stages in dstStageMask, as specified in the table of supported access types. Fixes the said validation error.
revert Fix VUID error 02816

[ VUID-vkCmdPipelineBarrier-dstAccessMask-02816 ] The Vulkan spec states: The dstAccessMask member of each element of pMemoryBarriers must only include access flags that are supported by one or more of the pipeline stages in dstStageMask, as specified in the table of supported access types. Fixes the said validation error.
Author
Member

This should have a value setting like 0.25, 0.5,etc because 1.0f will cause performance issues on android

This should have a value setting like 0.25, 0.5,etc because 1.0f will cause performance issues on android
Member

@wildcard wrote in #218 (comment):

This should have a value setting like 0.25, 0.5,etc because 1.0f will cause performance issues on android

What do you think about making a slider or something? How much does the perf decrease too? It's expected to have some performance impact as it's quality focused.

@wildcard wrote in https://git.eden-emu.dev/eden-emu/eden/pulls/218#issuecomment-1485: > This should have a value setting like 0.25, 0.5,etc because 1.0f will cause performance issues on android What do you think about making a slider or something? How much does the perf decrease too? It's expected to have some performance impact as it's quality focused.
Owner

I'll just add it like FSR sharpness

I'll just add it like FSR sharpness
crueter force-pushed FixSampleShading from 4d5b22ee09 to 35f99a9ca5 2025-08-07 22:36:56 +02:00 Compare
crueter force-pushed FixSampleShading from 35f99a9ca5 to 1da491671a 2025-08-07 22:37:15 +02:00 Compare
Shinmegumi force-pushed FixSampleShading from 5073029267 to 6ed085037a 2025-08-08 22:27:15 +02:00 Compare
crueter force-pushed FixSampleShading from 6ed085037a to 184240c491 2025-08-11 23:39:53 +02:00 Compare
Shinmegumi force-pushed FixSampleShading from 184240c491 to e4331fc703 2025-08-13 15:40:21 +02:00 Compare
Shinmegumi added this to the 0.0.3 Release Candidate PRs project 2025-08-13 15:43:12 +02:00
Shinmegumi force-pushed FixSampleShading from e4331fc703 to f50488b1a6 2025-08-14 14:45:18 +02:00 Compare
crueter scheduled this pull request to auto merge when all checks succeed 2025-08-15 01:17:32 +02:00
crueter approved these changes 2025-08-15 01:17:36 +02:00
crueter merged commit 394ee0dc82 into master 2025-08-15 01:17:39 +02:00
crueter deleted branch FixSampleShading 2025-08-15 01:17:40 +02:00
crueter referenced this pull request from a commit 2025-08-15 01:17:40 +02:00
Sign in to join this conversation.
No description provided.