[texture_cache] Enforce conservative 3D texture aliasing. Consistently merge/lookup images. #196

Merged
crueter merged 1 commit from weakboson/eden:strict-3d-cache-aliasing into master 2025-08-04 18:39:18 +02:00
Contributor

Previously, the merging strategy is permissive but the lookup strategy is strict. Together they create a infinite merge loop because lookup always fails and merges are always executed.
The last attempt to fix this issue made the lookup strategy more permissive which created unexpected aliased textures.
This commit implements an alternative: make the merging strategy strict.

Previously, the merging strategy is permissive but the lookup strategy is strict. Together they create a infinite merge loop because lookup always fails and merges are always executed. The last attempt to fix this issue made the lookup strategy more permissive which created unexpected aliased textures. This commit implements an alternative: make the merging strategy strict.
weakboson added 1 commit 2025-08-03 20:13:44 +02:00
[texture_cache] Enforce conservative 3D texture aliasing. Consistently merge/lookup images.
All checks were successful
eden-license / license-header (pull_request) Successful in 17s
b2b1679ca3
Previously, the merging strategy is permissive but the lookup strategy is strict. Together they create a infinite merge loop because lookup always fails and merges are always executed.
The last attempt to fix this issue made the lookup strategy more permissive which created unexpected aliased textures.
This commit implements an alternative: make the merging strategy strict.
Shinmegumi reviewed 2025-08-03 21:23:36 +02:00
Shinmegumi left a comment
Owner

I can confirm that XC2 is cleared up on Windows and AMD. Found no issues with performance or any other rendering artifacts in games that I tested.

I can confirm that XC2 is cleared up on Windows and AMD. Found no issues with performance or any other rendering artifacts in games that I tested.
Shinmegumi approved these changes 2025-08-04 18:38:26 +02:00
Shinmegumi left a comment
Owner

This can be merged. No further issues have been reported and it has been tested by members of the team as well.

This can be merged. No further issues have been reported and it has been tested by members of the team as well.
crueter merged commit 33275c28d3 into master 2025-08-04 18:39:18 +02:00
crueter deleted branch strict-3d-cache-aliasing 2025-08-04 18:39:19 +02:00
crueter referenced this pull request from a commit 2025-08-08 02:45:52 +02:00
Sign in to join this conversation.
No description provided.