[shader_recompiler/Maxwell] Rewrite ISBERD and fix potential downsides #192

Closed

SDK-Chan wants to merge 3 commits from rewrite-ISBERD into master

SDK-Chan commented

2025-08-03 18:17:26 +02:00

Member

The ISBERD implementation before had some flaws especially with skew and shift, as they can be used together with isberd.o and isberd.mode.
Skew however can also be used alone.
The previous implementation could have caused corruptions due to operations being used without real context.
Hopefully this is now fixed.

The ISBERD implementation before had some flaws especially with skew and shift, as they can be used together with isberd.o and isberd.mode. Skew however can also be used alone. The previous implementation could have caused corruptions due to operations being used without real context. Hopefully this is now fixed.

SDK-Chan added 1 commit 2025-08-03 18:17:26 +02:00

[shader_recompiler/Maxwell] Rewrite ISBERD and fix potential downsides

eden-license / license-header (pull_request) Successful in 15s

Details

d63b68f357

CamilleLaVey approved these changes 2025-08-03 18:20:18 +02:00

Dismissed

SDK-Chan added 1 commit 2025-08-04 11:26:48 +02:00

Update src/shader_recompiler/frontend/maxwell/translate/impl/internal_stage_buffer_entry_read.cpp

eden-license / license-header (pull_request) Successful in 16s

Details

7323ffeb45

Forgot to add the fallback if everything else in ISBERD results do default.

SDK-Chan dismissed CamilleLaVey's review 2025-08-04 11:26:48 +02:00

Reason:

New commits pushed, approval review dismissed automatically according to repository settings

SDK-Chan added 1 commit 2025-08-04 11:31:22 +02:00

Update src/shader_recompiler/frontend/maxwell/translate/impl/internal_stage_buffer_entry_read.cpp

eden-license / license-header (pull_request) Successful in 18s

Details

ccbd4f4bfd

Shinmegumi approved these changes 2025-08-04 16:36:58 +02:00

Shinmegumi left a comment

Owner

Checked the two games that did not work in previous version of the commit. Worked as intended. Could find no other games with issues. Everything else seems to run as expected.

I approve these changes and believe this to be ready to merge from a Windows perspective.

Checked the two games that did not work in previous version of the commit. Worked as intended. Could find no other games with issues. Everything else seems to run as expected. I approve these changes and believe this to be ready to merge from a Windows perspective.