Compare commits

...

10 commits

Author SHA1 Message Date
1de7697e37 revert 0c6ed79398
All checks were successful
eden-license / license-header (pull_request) Successful in 31s
revert apply alpha 3.5 patch
2025-07-21 07:14:32 +02:00
843d6fcbfe little fix after amicuchu changes
All checks were successful
eden-license / license-header (pull_request) Successful in 24s
2025-07-19 14:05:42 +02:00
dd11abfdbb add: amimi's changes
All checks were successful
eden-license / license-header (pull_request) Successful in 23s
2025-07-19 14:03:57 +02:00
f248e6f721 add history vector initialization
All checks were successful
eden-license / license-header (pull_request) Successful in 24s
2025-07-19 13:23:09 +02:00
83ec5869d7 structure changes 2025-07-19 03:59:04 +02:00
7cf2b860b4 add assert size info for BufferInfo
All checks were successful
eden-license / license-header (pull_request) Successful in 27s
2025-07-19 03:22:28 +02:00
6ccca5a0cf change BufferInfo to struct and pack it + use timestamp in queue_time
All checks were successful
eden-license / license-header (pull_request) Successful in 27s
2025-07-19 03:14:54 +02:00
0c6ed79398 apply alpha 3.5 patch
All checks were successful
eden-license / license-header (pull_request) Successful in 23s
2025-07-19 02:40:57 +02:00
dae8935302 fix compilation issue lol
All checks were successful
eden-license / license-header (pull_request) Successful in 23s
2025-07-19 02:34:51 +02:00
210159637f add sudachi getbufferhistory implementation
Some checks failed
eden-license / license-header (pull_request) Failing after 24s
2025-07-19 02:11:17 +02:00
6 changed files with 79 additions and 8 deletions

View file

@ -101,6 +101,14 @@ Status BufferQueueConsumer::AcquireBuffer(BufferItem* out_buffer,
// slot to the producer, it will wait for the fence to pass. We should fix this
// by properly waiting for the fence in the BufferItemConsumer.
// slots[slot].fence = Fence::NoFence();
const auto target_frame_number = slots[slot].frame_number;
for (size_t i = 0; i < core->history.size(); i++) {
if (core->history[i].frame_number == target_frame_number) {
core->history[i].state = BufferState::Acquired;
break;
}
}
}
// If the buffer has previously been acquired by the consumer, set graphic_buffer to nullptr to

View file

@ -10,7 +10,9 @@
namespace Service::android {
BufferQueueCore::BufferQueueCore() = default;
BufferQueueCore::BufferQueueCore() {
history.resize(8);
};
BufferQueueCore::~BufferQueueCore() = default;

View file

@ -21,6 +21,25 @@
namespace Service::android {
#ifdef _MSC_VER
#pragma pack(push, 1)
#endif
struct BufferInfo {
u64 frame_number;
s64 queue_time;
s64 presentation_time{};
BufferState state{BufferState::Free};
}
#if defined(__GNUC__) || defined(__clang__)
__attribute__((packed))
#endif
;
#ifdef _MSC_VER
#pragma pack(pop)
#endif
static_assert(sizeof(BufferInfo) == 0x1C,
"BufferInfo is an invalid size");
class IConsumerListener;
class IProducerListener;
@ -72,6 +91,8 @@ private:
u32 transform_hint{};
bool is_allocating{};
mutable std::condition_variable_any is_allocating_condition;
std::vector<BufferInfo> history{8};
};
} // namespace Service::android

View file

@ -512,6 +512,8 @@ Status BufferQueueProducer::QueueBuffer(s32 slot, const QueueBufferInput& input,
slots[slot].buffer_state = BufferState::Queued;
++core->frame_counter;
slots[slot].frame_number = core->frame_counter;
slots[slot].queue_time = timestamp;
slots[slot].presentation_time = 0;
item.acquire_called = slots[slot].acquire_called;
item.graphic_buffer = slots[slot].graphic_buffer;
@ -528,6 +530,11 @@ Status BufferQueueProducer::QueueBuffer(s32 slot, const QueueBufferInput& input,
item.is_droppable = core->dequeue_buffer_cannot_block || async;
item.swap_interval = swap_interval;
position = (position + 1) % 8;
core->history[position] = {.frame_number = core->frame_counter,
.queue_time = slots[slot].queue_time,
.state = BufferState::Queued};
sticky_transform = sticky_transform_;
if (core->queue.empty()) {
@ -803,6 +810,10 @@ Status BufferQueueProducer::SetPreallocatedBuffer(s32 slot,
return Status::NoError;
}
Kernel::KReadableEvent* BufferQueueProducer::GetNativeHandle(u32 type_id) {
return &buffer_wait_event->GetReadableEvent();
}
void BufferQueueProducer::Transact(u32 code, std::span<const u8> parcel_data,
std::span<u8> parcel_reply, u32 flags) {
// Values used by BnGraphicBufferProducer onTransact
@ -922,23 +933,49 @@ void BufferQueueProducer::Transact(u32 code, std::span<const u8> parcel_data,
status = SetBufferCount(buffer_count);
break;
}
case TransactionId::GetBufferHistory:
LOG_WARNING(Service_Nvnflinger, "(STUBBED) called, transaction=GetBufferHistory");
case TransactionId::GetBufferHistory: {
LOG_WARNING(Service_Nvnflinger, "called, transaction=GetBufferHistory");
std::scoped_lock lock{core->mutex};
auto buffer_history_count = std::min(parcel_in.Read<s32>(), (s32)core->history.size());
if (buffer_history_count <= 0) {
parcel_out.Write(Status::BadValue);
parcel_out.Write<s32>(0);
status = Status::None;
break;
}
auto info = new BufferInfo[buffer_history_count];
auto pos = position;
for (int i = 0; i < buffer_history_count; i++) {
info[i] = core->history[(pos - i) % core->history.size()];
LOG_WARNING(Service_Nvnflinger, "frame_number={}, state={}",
core->history[(pos - i) % core->history.size()].frame_number,
(u32)core->history[(pos - i) % core->history.size()].state);
pos--;
}
parcel_out.Write(Status::NoError);
parcel_out.Write(buffer_history_count);
parcel_out.WriteFlattenedObject<BufferInfo>(info);
status = Status::None;
break;
}
default:
ASSERT_MSG(false, "Unimplemented TransactionId {}", code);
break;
}
parcel_out.Write(status);
if (status != Status::None) {
parcel_out.Write(status);
}
const auto serialized = parcel_out.Serialize();
std::memcpy(parcel_reply.data(), serialized.data(),
std::min(parcel_reply.size(), serialized.size()));
}
Kernel::KReadableEvent* BufferQueueProducer::GetNativeHandle(u32 type_id) {
return &buffer_wait_event->GetReadableEvent();
}
} // namespace Service::android

View file

@ -86,6 +86,8 @@ private:
s32 current_callback_ticket{};
std::condition_variable_any callback_condition;
u64 position;
Service::Nvidia::NvCore::NvMap& nvmap;
};

View file

@ -15,7 +15,7 @@ namespace Service::android {
class GraphicBuffer;
enum class BufferState : u32 {
enum class BufferState : s32 {
Free = 0,
Dequeued = 1,
Queued = 2,
@ -34,6 +34,7 @@ struct BufferSlot final {
bool needs_cleanup_on_release{};
bool attached_by_consumer{};
bool is_preallocated{};
s64 queue_time{}, presentation_time{};
};
} // namespace Service::android