[ci] license-header.sh: Fix some shellcheck warnings

Signed-off-by: Caio Oliveira <caiooliveirafarias0@gmail.com>

.ci/license-header.sh

@@ -5,9 +5,7 @@
 
 # specify full path if dupes may exist
 EXCLUDE_FILES="CPM.cmake CPMUtil.cmake GetSCMRev.cmake"
-EXCLUDE_FILES=$(sed "s/ /\\\\|/g" <<< "$EXCLUDE_FILES")
-
-echo $EXCLUDE_FILES
+EXCLUDE_FILES=$(echo "$EXCLUDE_FILES" | sed 's/ /|/g')
 
 COPYRIGHT_YEAR="2025"
 COPYRIGHT_OWNER="Eden Emulator Project"
@@ -55,8 +53,8 @@ if git diff --quiet "$BASE"..HEAD; then
     echo "license-header.sh: No commits on this branch different from master."
     exit 0
 fi
-FILES=$(git diff --name-only "$BASE" | grep -v "$EXCLUDE_FILES")
-echo $FILES
+FILES=$(git diff --name-only "$BASE" | grep -E -v "$EXCLUDE_FILES")
+
 echo_header() {
     COMMENT_TYPE="$1"
     echo "$COMMENT_TYPE SPDX-FileCopyrightText: Copyright $COPYRIGHT_YEAR $COPYRIGHT_OWNER"
@@ -142,10 +140,10 @@ cat << EOF
   other files have been reviewed and addressed.
 EOF
 
-TMP_DIR=$(mktemp -d /tmp/license-header.XXXXXX) || exit 1
+TMP_DIR=$(mktemp -d "/tmp/license-header.XXXXXX") || exit 1
 if [ "$FIX" = "true" ] || [ "$UPDATE" = "true" ]; then
     echo
-    echo "license-header.sh: FIX set to true, fixing headers..."
+    echo "license-header.sh: FIX or UPDATE set to true, fixing headers..."
 
     for file in $SRC_FILES $OTHER_FILES; do
         BASENAME=$(basename "$file")
@@ -165,7 +163,7 @@ if [ "$FIX" = "true" ] || [ "$UPDATE" = "true" ]; then
         TMP="$TMP_DIR/$BASENAME.tmp"
         UPDATED=0
         cp -p "$file" "$TMP"
-        > "$TMP"
+        : > "$TMP"
 
         # this logic is bit hacky but sed don't work well with $VARIABLES
         # it's this or complete remove this logic and keep only the old way

CMakeLists.txt

@@ -147,7 +147,11 @@ if (MSVC OR ANDROID)
     set(EXT_DEFAULT ON)
 endif()
 
-CMAKE_DEPENDENT_OPTION(YUZU_USE_EXTERNAL_SDL2 "Compile external SDL2" ${EXT_DEFAULT} "ENABLE_SDL2;NOT MSVC" OFF)
+if (ENABLE_SDL2)
+    # TODO(crueter): Cleanup, each dep that has a bundled option should allow to choose between bundled, external, system
+    CMAKE_DEPENDENT_OPTION(YUZU_USE_EXTERNAL_SDL2 "Compile external SDL2" OFF "NOT MSVC" OFF)
+    option(YUZU_USE_BUNDLED_SDL2 "Download bundled SDL2 build" "${MSVC}")
+endif()
 
 cmake_dependent_option(ENABLE_LIBUSB "Enable the use of LibUSB" ON "NOT ANDROID" OFF)
 
@@ -185,8 +189,6 @@ option(YUZU_USE_PRECOMPILED_HEADERS "Use precompiled headers" ${EXT_DEFAULT})
 # TODO(crueter): CI this?
 option(YUZU_DOWNLOAD_ANDROID_VVL "Download validation layer binary for android" ON)
 
-# TODO(crueter): Cleanup, each dep that has a bundled option should allow to choose between bundled, external, system
-CMAKE_DEPENDENT_OPTION(YUZU_USE_BUNDLED_SDL2 "Download bundled SDL2 build" "${MSVC}" "ENABLE_SDL2" OFF)
 
 CMAKE_DEPENDENT_OPTION(YUZU_ROOM "Enable dedicated room functionality" ON "NOT ANDROID" OFF)
 
@@ -197,6 +199,14 @@ CMAKE_DEPENDENT_OPTION(YUZU_CMD "Compile the eden-cli executable" ON "ENABLE_SDL
 CMAKE_DEPENDENT_OPTION(YUZU_CRASH_DUMPS "Compile crash dump (Minidump) support" OFF "WIN32 OR LINUX" OFF)
 
 option(YUZU_ENABLE_LTO "Enable link-time optimization" OFF)
+if(YUZU_ENABLE_LTO)
+    include(CheckIPOSupported)
+    check_ipo_supported(RESULT COMPILER_SUPPORTS_LTO)
+    if(NOT COMPILER_SUPPORTS_LTO)
+        message(FATAL_ERROR "Your compiler does not support interprocedural optimization (IPO). Re-run CMake with -DYUZU_ENABLE_LTO=OFF.")
+    endif()
+    set(CMAKE_INTERPROCEDURAL_OPTIMIZATION ${COMPILER_SUPPORTS_LTO})
+endif()
 
 option(YUZU_DOWNLOAD_TIME_ZONE_DATA "Always download time zone binaries" ON)
 
@@ -310,6 +320,7 @@ endif()
 if (ARCHITECTURE_arm64 AND (ANDROID OR PLATFORM_LINUX))
     set(HAS_NCE 1)
     add_compile_definitions(HAS_NCE=1)
+    find_package(oaknut 2.0.1)
 endif()
 
 if (YUZU_ROOM)
@@ -883,19 +894,25 @@ if (MSVC AND CXX_CLANG)
     link_libraries(llvm-mingw-runtime)
 endif()
 
-if (YUZU_USE_FASTER_LD AND CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
-    # We will assume that if the compiler is GCC, it will attempt to use ld.bfd by default.
-    # Try to pick a faster linker.
+if (YUZU_USE_FASTER_LD)
+    # clang should always use lld
     find_program(LLD lld)
-    find_program(MOLD mold)
 
-    if (MOLD AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL "12.1")
-        message(NOTICE "Selecting mold as linker")
-        add_link_options("-fuse-ld=mold")
-    elseif (LLD)
-        message(NOTICE "Selecting lld as linker")
-        add_link_options("-fuse-ld=lld")
+    if (LLD)
+        set(LINKER lld)
     endif()
+
+    # GNU appears to work better with mold
+    # TODO: mold has been slow lately, see if better options exist (search for gold?)
+    if (CXX_GCC)
+        find_program(MOLD mold)
+        if (MOLD AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL "12.1")
+            set(LINKER mold)
+        endif()
+    endif()
+
+    message(NOTICE "Selecting ${LINKER} as linker")
+    add_link_options("-fuse-ld=${LINKER}")
 endif()
 
 # Set runtime library to MD/MDd for all configurations

CMakeModules/Findsirit.cmake

@@ -1,11 +0,0 @@
-# SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project
-# SPDX-License-Identifier: GPL-3.0-or-later
-
-include(FindPackageHandleStandardArgs)
-
-find_package(PkgConfig QUIET)
-pkg_search_module(sirit QUIET IMPORTED_TARGET sirit)
-find_package_handle_standard_args(sirit
-    REQUIRED_VARS sirit_LINK_LIBRARIES
-    VERSION_VAR sirit_VERSION
-)