From fd21774aaef60bc5b8e5aa85d5da8166e728cafa Mon Sep 17 00:00:00 2001 From: lizzie Date: Thu, 25 Sep 2025 17:08:43 +0200 Subject: [PATCH] [common] remove nvidia driver hack using environment variables (#2575) Ugly hack that helped boost FPS on OpenGL backend... or does it? https://download.nvidia.com/XFree86/Linux-x86_64/435.17/README/openglenvvariables.html This shouldn't work on Windows properly, as it is meant to be a Linux only thing anyways... so? Signed-off-by: lizzie Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/2575 Reviewed-by: MaranBr Reviewed-by: Shinmegumi Reviewed-by: crueter Co-authored-by: lizzie Co-committed-by: lizzie --- src/common/CMakeLists.txt | 2 -- src/common/nvidia_flags.cpp | 32 -------------------------------- src/common/nvidia_flags.h | 11 ----------- src/yuzu/main.cpp | 2 -- src/yuzu_cmd/yuzu.cpp | 3 --- 5 files changed, 50 deletions(-) delete mode 100644 src/common/nvidia_flags.cpp delete mode 100644 src/common/nvidia_flags.h diff --git a/src/common/CMakeLists.txt b/src/common/CMakeLists.txt index 665143900a..7759ea6a21 100644 --- a/src/common/CMakeLists.txt +++ b/src/common/CMakeLists.txt @@ -97,8 +97,6 @@ add_library( memory_detect.h multi_level_page_table.cpp multi_level_page_table.h - nvidia_flags.cpp - nvidia_flags.h overflow.h page_table.cpp page_table.h diff --git a/src/common/nvidia_flags.cpp b/src/common/nvidia_flags.cpp deleted file mode 100644 index baca31b0ac..0000000000 --- a/src/common/nvidia_flags.cpp +++ /dev/null @@ -1,32 +0,0 @@ -// SPDX-FileCopyrightText: Copyright 2021 yuzu Emulator Project -// SPDX-License-Identifier: GPL-2.0-or-later - -#include - -#include - -#include "common/fs/fs.h" -#include "common/fs/path_util.h" -#include "common/nvidia_flags.h" - -namespace Common { - -void ConfigureNvidiaEnvironmentFlags() { -#ifdef _WIN32 - const auto nvidia_shader_dir = - Common::FS::GetEdenPath(Common::FS::EdenPath::ShaderDir) / "nvidia"; - - if (!Common::FS::CreateDirs(nvidia_shader_dir)) { - return; - } - - const auto windows_path_string = - Common::FS::PathToUTF8String(nvidia_shader_dir.lexically_normal()); - - void(_putenv(fmt::format("__GL_SHADER_DISK_CACHE_PATH={}", windows_path_string).c_str())); - void(_putenv("__GL_SHADER_DISK_CACHE_SKIP_CLEANUP=1")); - void(_putenv("__GL_THREADED_OPTIMIZATIONS=1")); -#endif -} - -} // namespace Common diff --git a/src/common/nvidia_flags.h b/src/common/nvidia_flags.h deleted file mode 100644 index 8c3b1bfb92..0000000000 --- a/src/common/nvidia_flags.h +++ /dev/null @@ -1,11 +0,0 @@ -// SPDX-FileCopyrightText: Copyright 2021 yuzu Emulator Project -// SPDX-License-Identifier: GPL-2.0-or-later - -#pragma once - -namespace Common { - -/// Configure platform specific flags for Nvidia's driver -void ConfigureNvidiaEnvironmentFlags(); - -} // namespace Common diff --git a/src/yuzu/main.cpp b/src/yuzu/main.cpp index 19162a4ab7..d2c12c9d40 100644 --- a/src/yuzu/main.cpp +++ b/src/yuzu/main.cpp @@ -35,7 +35,6 @@ #include "applets/qt_profile_select.h" #include "applets/qt_software_keyboard.h" #include "applets/qt_web_browser.h" -#include "common/nvidia_flags.h" #include "common/settings_enums.h" #include "configuration/configure_input.h" #include "configuration/configure_per_game.h" @@ -4917,7 +4916,6 @@ int main(int argc, char* argv[]) { #endif Common::DetachedTasks detached_tasks; - Common::ConfigureNvidiaEnvironmentFlags(); // Init settings params QCoreApplication::setOrganizationName(QStringLiteral("eden")); diff --git a/src/yuzu_cmd/yuzu.cpp b/src/yuzu_cmd/yuzu.cpp index 599582aba9..4a99f34861 100644 --- a/src/yuzu_cmd/yuzu.cpp +++ b/src/yuzu_cmd/yuzu.cpp @@ -16,7 +16,6 @@ #include "common/detached_tasks.h" #include "common/logging/backend.h" #include "common/logging/log.h" -#include "common/nvidia_flags.h" #include "common/scm_rev.h" #include "common/scope_exit.h" #include "common/settings.h" @@ -334,8 +333,6 @@ int main(int argc, char** argv) { LocalFree(argv_w); #endif - Common::ConfigureNvidiaEnvironmentFlags(); - if (filepath.empty()) { LOG_CRITICAL(Frontend, "Failed to load ROM: No ROM specified"); return -1;