From cbfcc55c29d77ee6dd5ce1b838a082117f59be4c Mon Sep 17 00:00:00 2001 From: MaranBr Date: Tue, 26 Aug 2025 21:09:01 -0400 Subject: [PATCH] Change variable name to better match the purpose of the option --- src/common/settings.cpp | 2 +- src/common/settings.h | 4 ++-- src/core/arm/dynarmic/arm_dynarmic_32.cpp | 2 +- src/core/arm/dynarmic/arm_dynarmic_64.cpp | 2 +- src/yuzu/configuration/shared_translation.cpp | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/common/settings.cpp b/src/common/settings.cpp index fdba7be99e..19140bce0d 100644 --- a/src/common/settings.cpp +++ b/src/common/settings.cpp @@ -159,7 +159,7 @@ bool IsFastmemEnabled() { return static_cast(values.cpuopt_fastmem); } if (Settings::values.cpu_accuracy.GetValue() == Settings::CpuAccuracy::Unsafe) { - return static_cast(values.cpuopt_unsafe_mmu); + return static_cast(values.cpuopt_unsafe_host_mmu); } #if defined(__FreeBSD__) || defined(__OpenBSD__) || defined(__sun__) return false; diff --git a/src/common/settings.h b/src/common/settings.h index c2f1562011..d2411c3e5a 100644 --- a/src/common/settings.h +++ b/src/common/settings.h @@ -300,13 +300,13 @@ struct Values { Setting cpuopt_ignore_memory_aborts{linkage, true, "cpuopt_ignore_memory_aborts", Category::CpuDebug}; - SwitchableSetting cpuopt_unsafe_mmu{linkage, + SwitchableSetting cpuopt_unsafe_host_mmu{linkage, #if defined(__FreeBSD__) || defined(__OpenBSD__) || defined(__sun__) false, #else true, #endif - "cpuopt_unsafe_mmu", + "cpuopt_unsafe_host_mmu", Category::CpuUnsafe}; SwitchableSetting cpuopt_unsafe_unfuse_fma{linkage, true, "cpuopt_unsafe_unfuse_fma", Category::CpuUnsafe}; diff --git a/src/core/arm/dynarmic/arm_dynarmic_32.cpp b/src/core/arm/dynarmic/arm_dynarmic_32.cpp index 4de7eb7eb9..3626913b6d 100644 --- a/src/core/arm/dynarmic/arm_dynarmic_32.cpp +++ b/src/core/arm/dynarmic/arm_dynarmic_32.cpp @@ -272,7 +272,7 @@ std::shared_ptr ArmDynarmic32::MakeJit(Common::PageTable* pa // Unsafe optimizations if (Settings::values.cpu_accuracy.GetValue() == Settings::CpuAccuracy::Unsafe) { config.unsafe_optimizations = true; - if (!Settings::values.cpuopt_unsafe_mmu) { + if (!Settings::values.cpuopt_unsafe_host_mmu) { config.fastmem_pointer = std::nullopt; config.fastmem_exclusive_access = false; } diff --git a/src/core/arm/dynarmic/arm_dynarmic_64.cpp b/src/core/arm/dynarmic/arm_dynarmic_64.cpp index 0a63386c7f..a1274c692b 100644 --- a/src/core/arm/dynarmic/arm_dynarmic_64.cpp +++ b/src/core/arm/dynarmic/arm_dynarmic_64.cpp @@ -330,7 +330,7 @@ std::shared_ptr ArmDynarmic64::MakeJit(Common::PageTable* pa // Unsafe optimizations if (Settings::values.cpu_accuracy.GetValue() == Settings::CpuAccuracy::Unsafe) { config.unsafe_optimizations = true; - if (!Settings::values.cpuopt_unsafe_mmu) { + if (!Settings::values.cpuopt_unsafe_host_mmu) { config.fastmem_pointer = std::nullopt; config.fastmem_exclusive_access = false; } diff --git a/src/yuzu/configuration/shared_translation.cpp b/src/yuzu/configuration/shared_translation.cpp index 2795c9191e..fca4c94893 100644 --- a/src/yuzu/configuration/shared_translation.cpp +++ b/src/yuzu/configuration/shared_translation.cpp @@ -118,7 +118,7 @@ std::unique_ptr InitializeTranslations(QWidget* parent) // Cpu Debug // Cpu Unsafe - INSERT(Settings, cpuopt_unsafe_mmu, tr("Enable Host MMU Emulation (fastmem)"), + INSERT(Settings, cpuopt_unsafe_host_mmu, tr("Enable Host MMU Emulation (fastmem)"), tr("This optimization speeds up memory accesses by the guest program.\nEnabling it causes guest memory reads/writes to be done directly into memory and make use of Host's MMU.\nDisabling this forces all memory accesses to use Software MMU Emulation.")); INSERT( Settings,