eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 55 Projects 1 Releases Packages Wiki Activity Actions

Revert forced warp shuffle to fix some games (#385)
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
Details

Browse source 
Metroid Prime Remastered, Prince of Persia The Lost Crown, and maybe
some others.

A few testers and I couldn't find any game that this broke, but it fixed these two above and they said they got fewer artifacts from a few others.

Reviewed-on: #385
Reviewed-by: crueter <crueter@eden-emu.dev>
Reviewed-by: MaranBr <maranbr@eden-emu.dev>
Co-authored-by: Calchan <denis.dupeyron@gmail.com>
Co-committed-by: Calchan <denis.dupeyron@gmail.com>
This commit is contained in:
Calchan 2025-09-05 16:08:35 +02:00 • committed by crueter
parent 21433675e4
commit c0ebe85a74
Signed by: crueter
GPG key ID: 425ACD2D4830EBC6
1 changed files with 1 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

17
src/shader_recompiler/frontend/maxwell/translate/impl/warp_shuffle.cpp
View file

@ -7,7 +7,6 @@
#include "common/bit_field.h"
#include "common/common_types.h"
#include "shader_recompiler/frontend/maxwell/translate/impl/impl.h"
#include <fstream>
namespace Shader::Maxwell {
namespace {
@ -37,17 +36,6 @@ enum class ShuffleMode : u64 {
}
}
bool IsKONA() {
std::ifstream machineFile("/sys/devices/soc0/machine");
if (machineFile.is_open()) {
std::string line;
std::getline(machineFile, line);
if (line == "KONA")
return true;
}
return false;
}
void Shuffle(TranslatorVisitor& v, u64 insn, const IR::U32& index, const IR::U32& mask) {
union {
u64 insn;
@ -59,10 +47,7 @@ void Shuffle(TranslatorVisitor& v, u64 insn, const IR::U32& index, const IR::U32
const IR::U32 result{ShuffleOperation(v.ir, v.X(shfl.src_reg), index, mask, shfl.mode)};
v.ir.SetPred(shfl.pred, v.ir.GetInBoundsFromOp(result));
if (IsKONA())
v.X(shfl.dest_reg, v.ir.Imm32(0xffffffff)); // This fixes the freeze for Retroid / Snapdragon SD865
else
v.X(shfl.dest_reg, result);
v.X(shfl.dest_reg, result);
}
} // Anonymous namespace