eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 59 Projects 1 Releases Packages Wiki Activity Actions

[common/host_memory] use assert instead of throw on Impl() ctor; abort on error (#316)

Browse source 
Rationale: Throwing when running out of memory just creates sad paths for no reason (and at that point, just abort immediately). We are using MAP_NORESERVE, if there isn't enough memory a crash will follow anyways.

Signed-off-by: lizzie <lizzie@eden-emu.dev>

Reviewed-on: #316
Reviewed-by: crueter <crueter@eden-emu.dev>
Co-authored-by: lizzie <lizzie@eden-emu.dev>
Co-committed-by: lizzie <lizzie@eden-emu.dev>
This commit is contained in:
lizzie 2025-08-27 22:26:08 +02:00 • committed by crueter
parent 09e77fa146
commit 7950c5cca0
Signed by: crueter
GPG key ID: 425ACD2D4830EBC6
2 changed files with 8 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/core/arm/dynarmic/arm_dynarmic_32.cpp
View file

@ -175,7 +175,6 @@ public:
Kernel::KProcess* m_process{};
const bool m_debugger_enabled{};
const bool m_check_memory_access{};
static constexpr u64 MinimumRunCycles = 10000U;
};
std::shared_ptr<Dynarmic::A32::Jit> ArmDynarmic32::MakeJit(Common::PageTable* page_table) const {