eden-emu/eden
24
4
Fork 17
Code Issues 141 Pull requests 63 Projects 1 Releases Packages Wiki Activity Actions

file_sys/program_metadata: Remove obsolete TODOs

Browse source 
BitField has been trivially copyable since
b20657a36f, so we can eliminate these
TODO comments and use ReadObject() directly instead of memcpying the
data.
This commit is contained in:
Lioncash 2019-04-05 15:52:13 -04:00
parent 6e99d5146f
commit 633d55d503
2 changed files with 14 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/core/file_sys/program_metadata.h
View file

@ -58,7 +58,6 @@ public:
void Print() const;
private:
// TODO(DarkLordZach): BitField is not trivially copyable.
struct Header {
std::array<char, 4> magic;
std::array<u8, 8> reserved;
@ -85,7 +84,6 @@ private:
static_assert(sizeof(Header) == 0x80, "NPDM header structure size is wrong");
// TODO(DarkLordZach): BitField is not trivially copyable.
struct AcidHeader {
std::array<u8, 0x100> signature;
std::array<u8, 0x100> nca_modulus;