eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 60 Projects 1 Releases Packages Wiki Activity Actions

[dynarmic] disable xmm spills

Browse source 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
This commit is contained in:
lizzie 2025-08-04 21:54:18 +01:00 • committed by crueter
parent a563d9abbf
commit 343929c8e2
1 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/dynarmic/src/dynarmic/backend/x64/reg_alloc.cpp
View file

@ -527,8 +527,10 @@ void RegAlloc::Move(HostLoc to, HostLoc from) noexcept {
ASSERT(bit_width <= HostLocBitWidth(to)); ASSERT(bit_width <= HostLocBitWidth(to));
ASSERT_MSG(!LocInfo(from).IsEmpty(), "Mov eliminated"); ASSERT_MSG(!LocInfo(from).IsEmpty(), "Mov eliminated");
EmitMove(bit_width, to, from); if (!LocInfo(from).IsEmpty()) {
LocInfo(to) = std::exchange(LocInfo(from), {}); EmitMove(bit_width, to, from);
LocInfo(to) = std::exchange(LocInfo(from), {});
}
} }
void RegAlloc::CopyToScratch(size_t bit_width, HostLoc to, HostLoc from) noexcept { void RegAlloc::CopyToScratch(size_t bit_width, HostLoc to, HostLoc from) noexcept {
@ -567,12 +569,11 @@ void RegAlloc::SpillRegister(HostLoc loc) noexcept {
} }
HostLoc RegAlloc::FindFreeSpill(bool is_xmm) const noexcept { HostLoc RegAlloc::FindFreeSpill(bool is_xmm) const noexcept {
#ifdef _WIN32 #if 0
// TODO(lizzie): Ok, Windows hates XMM spills, this means less perf for windows // TODO(lizzie): Ok, Windows hates XMM spills, this means less perf for windows
// but it's fine anyways. We can find other ways to cheat it later - but which?!?! // but it's fine anyways. We can find other ways to cheat it later - but which?!?!
// we should NOT save xmm each block entering... MAYBE xbyak has a bug on start/end? // we should NOT save xmm each block entering... MAYBE xbyak has a bug on start/end?
// TODO(lizzie): This needs to be investigated further later. // TODO(lizzie): This needs to be investigated further later.
#else
// Do not spill XMM into other XMM silly // Do not spill XMM into other XMM silly
if (!is_xmm) { if (!is_xmm) {
// TODO(lizzie): Using lower (xmm0 and such) registers results in issues/crashes - INVESTIGATE WHY // TODO(lizzie): Using lower (xmm0 and such) registers results in issues/crashes - INVESTIGATE WHY