From 47b0ede755b5b58fe5a2a2ae4587dc39bd7b066c Mon Sep 17 00:00:00 2001 From: Shinmegumi Date: Mon, 4 Aug 2025 21:16:51 +0200 Subject: [PATCH] [vulkan] Fix VUID-VkImageMemoryBarrier-synchronization2-07794 Since we don't use synchronization2, the said layout is wrong and must be VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL. P.s. in future if we do use synchronization2, this change is compatible. --- src/video_core/renderer_vulkan/blit_image.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/video_core/renderer_vulkan/blit_image.cpp b/src/video_core/renderer_vulkan/blit_image.cpp index f2bf5a3228..37f0c74d26 100644 --- a/src/video_core/renderer_vulkan/blit_image.cpp +++ b/src/video_core/renderer_vulkan/blit_image.cpp @@ -518,7 +518,7 @@ void BlitImageHelper::BlitColor(const Framebuffer* dst_framebuffer, VkImageView scheduler.RequestOutsideRenderPassOperationContext(); scheduler.Record([this, dst_framebuffer, src_image_view, src_image, src_sampler, dst_region, src_region, src_size, pipeline, layout](vk::CommandBuffer cmdbuf) { - TransitionImageLayout(cmdbuf, src_image, VK_IMAGE_LAYOUT_READ_ONLY_OPTIMAL); + TransitionImageLayout(cmdbuf, src_image, VK_IMAGE_LAYOUT_GENERAL); BeginRenderPass(cmdbuf, dst_framebuffer); const VkDescriptorSet descriptor_set = one_texture_descriptor_allocator.Commit(); UpdateOneTextureDescriptorSet(device, descriptor_set, src_sampler, src_image_view);